docs: fix CSS Grid intro and drop React reference from templates page - #626
Merged
Conversation
The CSS Grid page had a stale flexbox-grid intro spliced in from layout/grid.mdx, which also displaced the "experimental and opt-in" warning; restore the section. The templates page description advertised "react admin panels".
Coverage Report for CI Build 30202024582Coverage increased (+0.03%) to 94.652%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two docs-only fixes found while comparing the free and PRO Bootstrap docs.
CSS Grid page
layout/css-grid.mdxhad a stale flexbox-grid intro spliced in fromlayout/grid.mdx("CoreUI Bootstrap's grid system uses a series of containers, rows, and columns…" plus a three-column example). That block also displaced the "Heads up—our CSS Grid system is experimental and opt-in as of v4.1.0!" warning, so the page never told readers the feature is off by default. The section now matchescoreui; the rest of the file was already identical.Templates page
The meta description advertised "easy-to-customize react admin panels". Companion fix in coreui/coreui#1140.
npm run docs-buildpasses (133 pages, no broken links);js-lintandcss-lintare clean.Note:
npm run js-test-karmaexits non-zero with "Some of your tests did a full page reload!" while reporting 3010/3010 SUCCESS. The same happens on a cleanmainin bothcoreuiandcoreui-pro, so it is unrelated to this change.